Skip to content
eth-rollup-develop branch workflow

Fix/rewards market GASP-1681 (#855) #809

Sign in to view logs

Fix/rewards market GASP-1681 (#855)

Fix/rewards market GASP-1681 (#855) #809

GitHub Actions / E2E report yarn test-poolliquidity failed Dec 6, 2024 in 0s

E2E report yarn test-poolliquidity ❌

Tests failed

❌ e2eTests/reports/junit.xml-d1979ba0-b3d3-11ef-83e5-45cdde26be34.xml

17 tests were completed in 463s with 15 passed, 2 failed and 0 skipped.

Test suite Passed Failed Skipped Time
test/parallel/xyk-pallet.API.pool.deactivatedPool.test.ts 7✅ 1❌ 455s
test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts 1✅ 1❌ 221s
test/parallel/xyk-pallet.API.poolLiqidity.activateLiqudity.test.ts 2✅ 107s
test/parallel/xyk-pallet.API.poolLiqudity.burnTokens.test.ts 2✅ 125s
test/parallel/xyk-pallet.API.poolLiqudity.multipleUserRewards.test.ts 2✅ 209s
test/parallel/xyk-pallet.API.poolLiqudity.sepClaimRewards.test.ts 1✅ 461s

❌ test/parallel/xyk-pallet.API.pool.deactivatedPool.test.ts

✅ GIVEN deactivated pool WHEN another user tries to create an equal pool THEN error returns
✅ GIVEN deactivated pool WHEN another user tries to mint liquidity in the pool THEN user can do this
✅ GIVEN deactivated pool WHEN the user mints liquidity in the pool again THEN liquidity IDs are equal
❌ GIVEN deactivated pool WHEN the user tries to swap/multiswap tokens on the deactivated pool THEN error returns
	Error: expect(received).toEqual(expected) // deep equality
✅ GIVEN deactivated pool WHEN sudo try to promote a pool THEN poolPromotion is updated
✅ GIVEN deactivated pool WHEN a bootstrap is scheduled for the existing pair THEN the operation fail with pool already exist.
✅ GIVEN deactivated pool WHEN call RPCs that work with the pools (e.g., calculate_buy_price_id) THEN zero returns
✅ GIVEN deactivated pool WHEN user tries to activate the pool THEN error returns

❌ test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts

✅ GIVEN user create a pool, wait for rewards and then deactivate the pool WHEN call RPC calculate_rewards_amount for this user AND user tries to claim rewards THEN value of amount returns AND rewards are claimed
❌ GIVEN  user create a pool, wait for rewards and then deactivate the pool WHEN the user tries to compound reward on a deactivated pool THEN error returns
	TypeError: Cannot read properties of undefined (reading 'compoundRewards')

✅ test/parallel/xyk-pallet.API.poolLiqidity.activateLiqudity.test.ts

✅ GIVEN a proofOfStake.updatePoolPromotion WHEN the liq token is a regular token, extrinsic fail
✅ Check that a user that deactivate some tokens, put liquidity tokens from frozen to free, then activate some tokens and put liquidity tokens from free to frozen

✅ test/parallel/xyk-pallet.API.poolLiqudity.burnTokens.test.ts

✅ Check that a user can burn tokens when they are activated, and when burning the free, those subtracted first
✅ Check that a user can burn some tokens on a non-promoted pool

✅ test/parallel/xyk-pallet.API.poolLiqudity.multipleUserRewards.test.ts

✅ Users minted a different number of tokens THEN they receive an equivalent amount of rewards
✅ One user mints X tokens, other mints those X tokens but splitted in 5 mints at the same block, rewards are equal

✅ test/parallel/xyk-pallet.API.poolLiqudity.sepClaimRewards.test.ts

✅ One user claim all the rewards on every session and other user claim them at the 3rd session, the sum of rewards are equal

Annotations

Check failure on line 0 in e2eTests/reports/junit.xml-d1979ba0-b3d3-11ef-83e5-45cdde26be34.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-poolliquidity

test/parallel/xyk-pallet.API.pool.deactivatedPool.test.ts ► GIVEN deactivated pool WHEN the user tries to swap/multiswap tokens on the deactivated pool THEN error returns 

Failed test found in:
  e2eTests/reports/junit.xml-d1979ba0-b3d3-11ef-83e5-45cdde26be34.xml
Error:
  Error: expect(received).toEqual(expected) // deep equality
Raw output 
Error: expect(received).toEqual(expected) // deep equality

Expected: "1010: Invalid Transaction: The swap prevalidation has failed"
Received: undefined
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/xyk-pallet.API.pool.deactivatedPool.test.ts:183:26
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/xyk-pallet.API.pool.deactivatedPool.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-d1979ba0-b3d3-11ef-83e5-45cdde26be34.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-poolliquidity

test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts ► GIVEN user create a pool, wait for rewards and then deactivate the pool WHEN the user tries to compound reward on a deactivated pool THEN error returns 

Failed test found in:
  e2eTests/reports/junit.xml-d1979ba0-b3d3-11ef-83e5-45cdde26be34.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'compoundRewards')
Raw output 
TypeError: Cannot read properties of undefined (reading 'compoundRewards')
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:1121:16
    at Generator.next (<anonymous>)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:13:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:9:12)
    at compoundRewards (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:676:12)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts:137:9
    at Generator.next (<anonymous>)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts:7:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts:3:12)
    at Object.<anonymous> (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/xyk-pallet.API.pool.deactivatedPromotedPool.test.ts:136:173)
    at Promise.then.completed (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/run.js:126:9)
    at run (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/jest-runner/build/testWorker.js:106:12)
View more details on GitHub Actions