Skip to content

Fix/rewards market GASP-1681 (#855) #809

Fix/rewards market GASP-1681 (#855)

Fix/rewards market GASP-1681 (#855) #809

GitHub Actions / E2E report yarn test-maintenance failed Dec 6, 2024 in 1s

E2E report yarn test-maintenance ❌

Tests failed

❌ e2eTests/reports/junit.xml-768d4f00-b3cb-11ef-adbc-9bef754b412f.xml

24 tests were completed in 942s with 23 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
test/sequential/maintenance-pallet.api.rolldown.test.ts 16✅ 642s
test/sequential/xyk-pallet.api.maintenance-config.test.ts 2✅ 1❌ 156s
test/sequential/xyk-pallet.api.maintenance-rules.test.ts 5✅ 144s

✅ test/sequential/maintenance-pallet.api.rolldown.test.ts

On [mm] - regular l1 updates must be forbidden › On [%s] - regular l1 updates must be forbidden
  ✅ updateL2fromL1 operation is not allowed in mm
  ✅ withdraw operation is not allowed in mm
  ✅ cancelRequestsFromL1 operation is not allowed in mm
  ✅ forceCancelRequestsFromL1 operation is not allowed in mm
  ✅ forceUpdateL2fromL1 operation is not allowed in mm
  ✅ sequencerSetup operations are allowed in mm
  ✅ sequencerTearDown operations are allowed in mm
  ✅ Update is blocked on maintenance mode but works on upgradeability
On [upgradabilityMm] - regular l1 updates must be forbidden › On [%s] - regular l1 updates must be forbidden
  ✅ updateL2fromL1 operation is not allowed in mm
  ✅ withdraw operation is not allowed in mm
  ✅ cancelRequestsFromL1 operation is not allowed in mm
  ✅ forceCancelRequestsFromL1 operation is not allowed in mm
  ✅ forceUpdateL2fromL1 operation is not allowed in mm
  ✅ sequencerSetup operations are allowed in mm
  ✅ sequencerTearDown operations are allowed in mm
  ✅ Update is blocked on maintenance mode but works on upgradeability

❌ test/sequential/xyk-pallet.api.maintenance-config.test.ts

✅ maintenance- try to change Maintenance Mode with a non-foundation account THEN it failed
✅ check UpgradabilityOn can only be set after MaintenanceModeOn is set and MaintenanceMode works without UpgradabilityOn
❌ maintenance- check we can sell MGX tokens and compoundRewards THEN switch maintenanceMode to on, repeat the operation and receive error
	TypeError: Cannot read properties of undefined (reading 'compoundRewards')

✅ test/sequential/xyk-pallet.api.maintenance-rules.test.ts

On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed
  ✅ multiswapSellAsset operation is not allowed in mm
  ✅ multiswapBuyAsset operation is not allowed in mm
  ✅ sellAsset operation is not allowed in mm
  ✅ buyAsset operation is not allowed in mm
On Maintenance mode - aggregators and candidates are allowed
  ✅ Join as candidate , Aggregate metadata and update CandidateAgg runs on Mm

Annotations

Check failure on line 0 in e2eTests/reports/junit.xml-768d4f00-b3cb-11ef-adbc-9bef754b412f.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-config.test.ts ► maintenance- check we can sell MGX tokens and compoundRewards THEN switch maintenanceMode to on, repeat the operation and receive error

Failed test found in:
  e2eTests/reports/junit.xml-768d4f00-b3cb-11ef-adbc-9bef754b412f.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'compoundRewards')
Raw output
TypeError: Cannot read properties of undefined (reading 'compoundRewards')
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:1121:16
    at Generator.next (<anonymous>)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:13:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:9:12)
    at compoundRewards (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/tx.ts:676:12)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-config.test.ts:193:9
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-config.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)