Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/liq tokens mgx 434 v2 #603

Merged
merged 29 commits into from
Sep 29, 2023

Removed duplicated code after auto merging

11a4749
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Bugfix/liq tokens mgx 434 v2 #603

Removed duplicated code after auto merging
11a4749
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / E2E report yarn test-multiswap succeeded Sep 28, 2023 in 0s

E2E report yarn test-multiswap ✔️

Tests passed successfully

✔️ e2eTests/reports/junit-3885f0d0-5e0a-11ee-8dfd-abdcd12f7aa7.xml

44 tests were completed in 982s with 43 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
test/parallel/utility-pallet.swapOperations.test.ts 24✔️ 1✖️ 980s
test/parallel/xyk-pallet.multiswap.errors.test.ts 7✔️ 549s
test/parallel/xyk-pallet.multiswap.test.ts 7✔️ 440s
test/parallel/xyk-pallet.multiswap2hops.test.ts 5✔️ 297s

✔️ test/parallel/utility-pallet.swapOperations.test.ts

✖️ Validate that the error enum is about filtered call
Utility - batched swaps are not allowed
  ✔️ multiswapSellAsset operation is not allowed in batchAll
  ✔️ multiswapBuyAsset operation is not allowed in batchAll
  ✔️ sellAsset operation is not allowed in batchAll
  ✔️ buyAsset operation is not allowed in batchAll
  ✔️ compoundRewards operation is not allowed in batchAll
  ✔️ provideLiquidity operation is not allowed in batchAll
  ✔️ multiswapSellAsset operation is not allowed in batch
  ✔️ multiswapBuyAsset operation is not allowed in batch
  ✔️ sellAsset operation is not allowed in batch
  ✔️ buyAsset operation is not allowed in batch
  ✔️ compoundRewards operation is not allowed in batch
  ✔️ provideLiquidity operation is not allowed in batch
  ✔️ multiswapSellAsset operation is not allowed in forceBatch
  ✔️ multiswapBuyAsset operation is not allowed in forceBatch
  ✔️ sellAsset operation is not allowed in forceBatch
  ✔️ buyAsset operation is not allowed in forceBatch
  ✔️ compoundRewards operation is not allowed in forceBatch
  ✔️ provideLiquidity operation is not allowed in forceBatch
  ✔️ multiswapSellAsset operation is not allowed in singleBatch with some allowed
  ✔️ multiswapBuyAsset operation is not allowed in singleBatch with some allowed
  ✔️ sellAsset operation is not allowed in singleBatch with some allowed
  ✔️ buyAsset operation is not allowed in singleBatch with some allowed
  ✔️ compoundRewards operation is not allowed in singleBatch with some allowed
  ✔️ provideLiquidity operation is not allowed in singleBatch with some allowed

✔️ test/parallel/xyk-pallet.multiswap.errors.test.ts

Multiswap - error cases: disabled tokens
  ✔️ [gasless] disabled on token of the chained polls
  ✔️ [gasless] disabled on token of the chained polls - Fail on tx execution-2
  ✔️ [gasless] disabled on token of the chained polls - Fail on tx execution-4
Multiswap - error cases: pool status & gasless integration
  ✔️ [gasless] High value swaps are disabled on multiswap
  ✔️ [gasless] Fail on client when not enough MGAs to lock AND tokens that exist whitelist
  ✔️ [gasless] Fail on swap when selling remove all MGAs
  ✔️ [gasless] Fails on client when pool does not exist

✔️ test/parallel/xyk-pallet.multiswap.test.ts

Multiswap - happy paths
  ✔️ [gasless] Happy path - multi-swap - buy
  ✔️ [gasless] Happy path - multi-swap - sell
  ✔️ [gasless] Happy path - multi-swap uses feeLocks
  ✔️ [gasless] Fees - multi-swap roll backs all the swaps when one fail but 0.3% is charged
  ✔️ [gasless] accuracy - Sum of calculate_sell_asset chained is equal to the multiswap operation
  ✔️ [gasless] accuracy - Sum of calculate_buy_asset chained is equal to the multiswap operation
  ✔️ [gasless] alternative scenario - one pool is highly unbalanced -> zero swap output

✔️ test/parallel/xyk-pallet.multiswap2hops.test.ts

Multiswap [2 hops] - happy paths
  ✔️ [gasless] Happy path - multi-swap - buy
  ✔️ [gasless] Happy path - multi-swap - sell
  ✔️ [gasless] Happy path - multi-swap uses feeLocks
  ✔️ [gasless] Fees - multi-swap roll backs all the swaps when one fail but 0.3% is charged
  ✔️ [gasless] accuracy - Sum of calculate_sell_asset chained is equal to the multiswap operation