Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/liq tokens mgx 434 v2 #603

Merged
merged 29 commits into from
Sep 29, 2023
Merged

Bugfix/liq tokens mgx 434 v2 #603

merged 29 commits into from
Sep 29, 2023

Conversation

majusko
Copy link
Member

@majusko majusko commented Sep 28, 2023

Added more validations for other extrinsic and APIs that interact with the pool. Basic test with the error trigger.

majusko added 29 commits May 12, 2023 13:40
…idity is changed so old pools are reused. Added RPC call to get filtered liq tokens that are available for traiding.
…iquidity is empty when minting new liquidity. Achieving reuse of existing pools.
…age. Also, fixed older test swaping on non-existing pool.
@majusko majusko requested a review from mateuszaaa September 28, 2023 12:37
@majusko majusko requested a review from vanderian September 28, 2023 12:37
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ff1226b) 49.91% compared to head (11a4749) 50.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #603      +/-   ##
===========================================
+ Coverage    49.91%   50.06%   +0.14%     
===========================================
  Files           29       29              
  Lines         4061     4067       +6     
===========================================
+ Hits          2027     2036       +9     
+ Misses        2034     2031       -3     
Files Coverage Δ
pallets/xyk/src/lib.rs 61.92% <100.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@majusko majusko merged commit 0ed4f51 into develop Sep 29, 2023
48 checks passed
@majusko majusko deleted the bugfix/liq-tokens-mgx-434-v2 branch September 29, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants