Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a DeprecationWarning when downloading the docker client #577

Merged

Conversation

LewisGaul
Copy link
Collaborator

As agreed in #512 (comment)

@LewisGaul LewisGaul force-pushed the LG-warn-docker-download branch from d1104d7 to e45e19c Compare April 8, 2024 22:36
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabrieldemarmiesse gabrieldemarmiesse enabled auto-merge (squash) April 10, 2024 17:23
@gabrieldemarmiesse gabrieldemarmiesse merged commit 4e0c80c into gabrieldemarmiesse:master Apr 10, 2024
35 checks passed
@LewisGaul LewisGaul deleted the LG-warn-docker-download branch May 29, 2024 17:17
gabrieldemarmiesse pushed a commit that referenced this pull request Oct 13, 2024
Removes dependency on typer/tqdm/requests by dropping support for
downloading the docker client.

Initially agreed at
#512 (comment),
this has been deprecated since
#577 (v0.71.0
released in April 2024), and agreed we can now remove at
#552 (comment).
If accepted, this supercedes
#513 as a
resolution to
#512. We
will also be able to close
#575.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants