Remove download docker client functionality #633
Conversation
|
@gabrieldemarmiesse are we ready to merge this do you think? |
There was a problem hiding this comment.
I'm deeply sorry for the late reply there. Thanks for the PR and the description. I believe we should have a section of the docs dedicated to installing the docker cli without the engine since people whose code won't work anymore will look for a solution and might not be aware that they need an apt-get or similar to replace the "download-cli". If you wish, that can be in another PR, but we should write that up before making a release.
|
Can we just link to https://docs.docker.com/engine/install/ and https://podman.io/docs/installation? Where in the docs were you thinking this should go? |
|
We should definitely link those. I'm not sure linking is enough, we should additionally tell users that they don't need the engine and containerd and don't need to use systemd or systemctl to create the docker service. The docker docs are not great if you just want to install the client so we should fill this gap. We just need to tell users what steps are not needed. We can also add a link to this in our README, just after the pip install. |
LewisGaul
force-pushed
the
reduce-deps
branch
from
c8310af to
77699af
Compare
gabrieldemarmiesse
merged commit 2e08c98
into
gabrieldemarmiesse:master
|
Oh, there are some doc updates I was still working on sorry, I'll have to raise in a separate PR |
|
Something fancy could also be to re-enable CLI entrypoint (without typer) just to print the message that CLI isn't supported by python-on-whales anymore, so that people using it don't just get the "command not found" error. But that's slightly more work. What do you think? |
|
Hm could do, unsure how many users would actually be relying on it... Here's the follow-up PR: #639 |
Removes dependency on typer/tqdm/requests by dropping support for downloading the docker client.
Initially agreed at #512 (comment), this has been deprecated since #577 (v0.71.0 released in April 2024), and agreed we can now remove at #552 (comment). If accepted, this supercedes #513 as a resolution to #512. We will also be able to close #575.