Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Console Vercel URL in staging yaml #514

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Add Console Vercel URL in staging yaml #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion k8s/helm/staging.yaml
View file
Open in desktop
Copy link
Contributor

@AliakseiMalyshau AliakseiMalyshau Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MusabShakeel576 why you specified regex for Helm values?

Copy link
Contributor

@NikolayRn NikolayRn Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliakseiMalyshau I was asked to review it , but as i understand its for Operator to function properly in Console Vercel:

https://console-dapp-staging-git-musab-featoperator-bi-48850a-fuse-labs.vercel.app/dashboard

Copy link
Contributor

@AliakseiMalyshau AliakseiMalyshau Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikolayRn it should be specified as is, not regex. It won't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliakseiMalyshau Console Vercel preview URL is dynamic, how can we specify them in Helm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliakseiMalyshau How can we make it dynamic?

Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ accounts:
etherspot_wallet_factory_production_contract_address_v_0_1_0: "0x7f6d8F107fE8551160BD5351d5F1514A6aD5d40E"
paymaster_funder_api_key: "pk_u_RbFw7NQBB7ZQIFJtziLE_S"
paymaster_funder_webhook_id: "65bbbc63fc2f925de8e1a561"
console_dapp_url: "https://console-staging.fuse.io"
console_dapp_url: /^https:\/\/(?:console-staging\.fuse\.io|console-dapp.*fuse-labs\.vercel\.app)$/

# Secret (external; sensitive information; pulled from Google Cloud, Secret Manager)
secret:
Expand Down