Add Console Vercel URL in staging yaml #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@MusabShakeel576 why you specified regex for Helm values?
There was a problem hiding this comment.
@AliakseiMalyshau I was asked to review it , but as i understand its for Operator to function properly in Console Vercel:
https://console-dapp-staging-git-musab-featoperator-bi-48850a-fuse-labs.vercel.app/dashboard
There was a problem hiding this comment.
@NikolayRn it should be specified as is, not regex. It won't work.
There was a problem hiding this comment.
@AliakseiMalyshau Console Vercel preview URL is dynamic, how can we specify them in Helm?
There was a problem hiding this comment.
@AliakseiMalyshau How can we make it dynamic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add Console Vercel URL in staging yaml
Types of changes