Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruleset for DR - Danish Broadcasting Corporation #151

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add ruleset for DR - Danish Broadcasting Corporation #151

merged 2 commits into from
Jan 12, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jan 11, 2024

Status

Ready for review

Fixes #150; note, this PR was generated using #147

Review Checklist

  • Changes to onboarded.txt are accurate
  • The file default.rulesets.TIMESTAMP.gz has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules
  • The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
  • index.html has been updated using ./update_index.sh

Post-Deployment Checklist

  • Added/modified onion names have been updated in the SecureDrop Directory

Copy link
Collaborator

@nathandyer nathandyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM, short onion name loaded perfectly in Tor browser with the new ruleset in place. Thanks @legoktm!

@nathandyer nathandyer merged commit 5a5524c into main Jan 12, 2024
5 checks passed
@nathandyer nathandyer deleted the dr branch January 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add short onion name for DR
2 participants