Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy upstream files for generation and signing #147

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Dec 18, 2023

Status

Ready for review

Description

  • Copy upstream files for generation and signing instead of cloning upstream
  • Apply black formatting
  • Update generate-and-sign to use the forked copies

Review Checklist

  • Doing an update with a test key succeeds
  • CI passes

The upstream EFF repository has been archived, so let's just maintain
our own copies instead of cloning the giant https-everywhere repository.
This will also let us fix some longstanding bugs in the tooling.

Fixes #143.
Same commands, just less moving of files around.
@legoktm
Copy link
Member Author

legoktm commented Jan 11, 2024

I generated #151 using this and it all worked fine!

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one more external dep to not worry about.

@zenmonkeykstop zenmonkeykstop merged commit 696adb2 into main Jan 11, 2024
4 checks passed
@legoktm legoktm deleted the updates branch January 11, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants