Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NUC 7 and 8 recommendation, remove Intel references, and update links #540
Remove NUC 7 and 8 recommendation, remove Intel references, and update links #540
Changes from all commits
5f098d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be language here to flag that these are EOL. Straight-up removing them from the docs is liable to cause confusion for folks still using them and looking for guidance.
For example "We previously recommended the name. As it has reached EOL, we recommend replacing it with a model which still has vendor support. Compatibility testing for the grsec kernel will continue for the next N server releases" (where N is a number we argue about)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to be along these lines, but instead of promising an explicit sunset timeline, I've said it'll likely work but we're going to stop explicitly testing on it.