-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NUC 7 and 8 recommendation, remove Intel references, and update links #540
Conversation
efaefbf
to
a759819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested, we shouldn't wait for the PR creator to be available for them tho :)
@@ -534,56 +534,6 @@ startup and adjust the system configuration: | |||
|
|||
.. |NUC10 leads| image:: ../../images/hardware/nuc10_leads.jpg | |||
|
|||
.. _nuc8_recommendation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be language here to flag that these are EOL. Straight-up removing them from the docs is liable to cause confusion for folks still using them and looking for guidance.
For example "We previously recommended the name. As it has reached EOL, we recommend replacing it with a model which still has vendor support. Compatibility testing for the grsec kernel will continue for the next N server releases" (where N is a number we argue about)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to be along these lines, but instead of promising an explicit sunset timeline, I've said it'll likely work but we're going to stop explicitly testing on it.
…e links This commit removes NUC 7 (which has already reached EOL) and NUC 8 (which reaches EOL next month) from our list of recommended NUC models. It also addresses changes as a result of Intel's decision to discontinue manufacturing NUCs, and reflects ASUS taking over the NUC line. For NUC 11 and 12, links are provided for the ASUS page. For NUC 10, which ASUS does not list, a simplynuc link is provided instead. This commit also removes references to Intel, where necessary.
a759819
to
5f098d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on visual review.
Status
Ready for review
Description of Changes
This PR removes NUC 7 (which has already reached EOL) and NUC 8 (which reaches EOL next month) from our list of recommended NUC models.
It also addresses changes as a result of Intel's decision to discontinue manufacturing NUCs, and reflects ASUS taking over the NUC line. For NUC 11 and 12, links are provided for the ASUS page. For NUC 10, which ASUS does not list, a simplynuc link is provided instead.
It also removes references to Intel, where necessary.
Testing
Release
Checklist (Optional)
make docs-lint
) passed locallymake docs-linkcheck
) passedmake docs
) docs at http://localhost:8000