@foxglove/ws-protocol: Update to spec changes #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Nov 6, 2023
achim-k
force-pushed
the
achim/ws-protocol-ts-spec-updates
branch
from
17d842f
to
d631a7a
Compare
jtbandes
approved these changes
Nov 9, 2023
| schemaEncoding: string; | ||
| schema: string; | ||
| }; | ||
| type ServiceResponseDefinition = ServiceRequestDefinition; |
There was a problem hiding this comment.
Is that bad practice?
3 tasks
achim-k
added a commit
that referenced
this pull request
Mar 21, 2024
### Public-Facing Changes Apply changes wrt. service definition to example server implementations ### Description - [X] C++ - [X] Python - [X] ~Typescript~ (done in #579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
@foxglove/ws-protocol: Update to spec changes
Description
Adapts @foxglove/ws-protocol to the latest spec changes made in #563
Related to FG-5280