Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply spec updates to c++ server implementation #709

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Mar 15, 2024

Public-Facing Changes

Apply changes wrt. service definition to example server implementations

Description

Copy link

linear bot commented Mar 15, 2024

@achim-k achim-k marked this pull request as draft March 15, 2024 20:24
@achim-k achim-k force-pushed the achim/fg-7166-apply-ws-protocol-spec-changes-to-server-implementations branch from e4a1869 to a2ef539 Compare March 18, 2024 14:10
@achim-k achim-k force-pushed the achim/fg-7166-apply-ws-protocol-spec-changes-to-server-implementations branch from a2ef539 to 3d79d97 Compare March 18, 2024 14:14
@achim-k achim-k marked this pull request as ready for review March 18, 2024 14:16
@achim-k achim-k requested a review from jtbandes March 18, 2024 14:16
cpp/foxglove-websocket/src/serialization.cpp Outdated Show resolved Hide resolved
cpp/foxglove-websocket/src/serialization.cpp Outdated Show resolved Hide resolved
python/src/foxglove_websocket/types.py Outdated Show resolved Hide resolved
@achim-k achim-k force-pushed the achim/fg-7166-apply-ws-protocol-spec-changes-to-server-implementations branch from d64c6ec to dc5f381 Compare March 21, 2024 00:54
@achim-k achim-k enabled auto-merge (squash) March 21, 2024 00:56
@achim-k achim-k merged commit 862b2ca into main Mar 21, 2024
12 checks passed
@achim-k achim-k deleted the achim/fg-7166-apply-ws-protocol-spec-changes-to-server-implementations branch March 21, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants