Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky integration tests (login helper?) #1006

Open
yksflip opened this issue Jun 10, 2023 · 1 comment
Open

fix flaky integration tests (login helper?) #1006

yksflip opened this issue Jun 10, 2023 · 1 comment
Labels
Milestone

Comments

@yksflip
Copy link
Member

yksflip commented Jun 10, 2023

 1) Order balancing charges correct amounts creates financial transaction with correct amount
    Failure/Error: expect(goa.result).to be > 0

      expected: > 0
           got:   0
    # ./spec/models/order_spec.rb:177:in `block (3 levels) in <top (required)>'
  2) product distribution agrees to documented example
     Failure/Error: expect(oa.quantity).to eq(6)

       expected: 6
            got: 5

       (compared using ==)
     # ./spec/integration/product_distribution_example_spec.rb:50:in `block (2 levels) in <top (required)>'
@yksflip yksflip added this to the 4.8 milestone Jun 10, 2023
@yksflip yksflip moved this to Next Release in Foodsoft roadmap Jun 10, 2023
@yksflip yksflip removed the status in Foodsoft roadmap Jul 12, 2023
@yksflip yksflip moved this to Prioritised in Foodsoft roadmap Sep 9, 2023
@yksflip yksflip modified the milestones: 4.8, 4.8.1 Oct 2, 2023
@yksflip
Copy link
Member Author

yksflip commented Nov 13, 2023

look's like the login method in session_helper.rb is flaky.
Here parts of the entered password ended up in the username field ... pretty weird. Maybe adding a wait: could help...

grafik
grafik

@yksflip yksflip changed the title fix test ./spec/models/order_spec.rb:177 fix flaky integration tests (login helper?) Nov 13, 2023
@yksflip yksflip modified the milestones: 4.8.1, 4.8.2 Jan 26, 2024
@yksflip yksflip added the bug label Mar 11, 2024
@yksflip yksflip modified the milestones: 4.8.2, 4.10 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prioritised
Development

No branches or pull requests

1 participant