Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress net protocol errors #1015

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Suppress net protocol errors #1015

merged 4 commits into from
Sep 19, 2023

Conversation

kidhab
Copy link
Contributor

@kidhab kidhab commented Jun 21, 2023

Adding these gems suppresses the following errors (see also ruby/net-imap#16):

/2.7.8/lib/ruby/2.7.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError
/2.7.8/lib/ruby/gems/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: previous definition of ProtocRetryError was here
/2.7.8/lib/ruby/2.7.0/net/protocol.rb:206: warning: already initialized constant Net::BufferedIO::BUFSIZE
/2.7.8/lib/ruby/gems/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:214: warning: previous definition of BUFSIZE was here
/2.7.8/lib/ruby/2.7.0/net/protocol.rb:503: warning: already initialized constant Net::NetPrivate::Socket
/2.7.8/lib/ruby/gems/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:541: warning: previous definition of Socket was here

@yksflip
Copy link
Member

yksflip commented Jul 4, 2023

great you've found a way to supress the error messages!

The ci pipeline fails with this error ...

You have already activated uri 0.10.0.2, but your Gemfile requires uri 0.12.1. Since uri is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports uri as a default gem. (Gem::LoadError)

have you tried updating the bundler verison already?

@kidhab
Copy link
Contributor Author

kidhab commented Sep 18, 2023

I set the exact version to avoid the CI error. Good enough to merge?

@yksflip
Copy link
Member

yksflip commented Sep 19, 2023

great kidhab! thank you!
I think the failed test is somehow flaky, I've opened already a issue to tackle that. #1006
LGTM

@yksflip yksflip merged commit bca4576 into foodcoops:master Sep 19, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants