Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feedback form #1028

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Remove feedback form #1028

merged 1 commit into from
Nov 13, 2023

Conversation

kidhab
Copy link
Contributor

@kidhab kidhab commented Sep 18, 2023

This MR removes the feedback form.

Personally I don't think there's a need for a regular Foodsoft user to contact some kind of unknown admin team behind an instances. It would be better to use the internal message system to direct problems to a person or group in charge.

In fact at apps.foodcoops.net all requests that came via the feedback form were non-technical questions directed at other foodcoop members/ groups. We were never able to answer such questions because we are not part of these foodcoops.
I think most people don't recognize the text above the form.

@yksflip
Copy link
Member

yksflip commented Sep 19, 2023

Yes, I agree! I think in general it's good to have some way to aggregate feedback. But I think a link to the forum would be fine too.
Could you fix the rubocop violations?
Any objections @lentschi @wvengen @paroga ?

@wvengen
Copy link
Member

wvengen commented Sep 19, 2023

Agree! 👍

@kidhab kidhab force-pushed the feedback_form branch 3 times, most recently from c470bbf to bc329fe Compare November 12, 2023 18:47
@kidhab
Copy link
Contributor Author

kidhab commented Nov 12, 2023

Could you fix the rubocop violations?

Done.

@yksflip
Copy link
Member

yksflip commented Nov 13, 2023

thanks, lgtm! I think the failing tests are flaky. #1006

@yksflip yksflip merged commit 9c81aa3 into master Nov 13, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants