Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix schema generation issues #63

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

AThePeanut4
Copy link
Contributor

This fixes a few issues relating to the CI json schema generation.

  • befcc1f fixes bug: rust-analyzer schema removed #60, and also fixes several other servers that previously had an empty properties in the schema. This happened because c.properties is a table, which means vim.list_extend doesn't do anything. properties should also always be an object and not an array, so vim.empty_dict() is now being used to prevent outputting [] when properties is empty.
  • 84e19f4 embeds index.json rather than downloading it every time. As mentioned in feature: update schema source #54, the gist is no longer maintained, so there's no reason to download it anymore. In the future this should probably be sourced from elsewhere.
  • 2a911fd fixes the URL for Volar.
  • 6dfd503 is just me running the build step locally. If I shouldn't have done this I'm happy to revert it.

Fixes #52
Fixes #60

@folke folke force-pushed the fix-schema-generation branch from 6dfd503 to 6b4baef Compare July 6, 2024 21:49
@folke folke force-pushed the fix-schema-generation branch from 6b4baef to 11e30c0 Compare July 6, 2024 21:51
@folke folke linked an issue Jul 6, 2024 that may be closed by this pull request
1 task
@folke folke merged commit 45484f5 into folke:main Jul 6, 2024
9 checks passed
@folke
Copy link
Owner

folke commented Jul 6, 2024

ty!

@AThePeanut4 AThePeanut4 deleted the fix-schema-generation branch July 6, 2024 21:53
folke pushed a commit that referenced this pull request Jul 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](v1.2.2...v1.3.0)
(2024-07-07)


### Features

* added support for ruff_lsp. Fixes
[#45](#45)
([a198a8c](a198a8c))
* **util:** util.pick_root_dir
([197c17a](197c17a))


### Bug Fixes

* **build:** fix schema generation issues
([#63](#63))
([45484f5](45484f5)),
closes [#52](#52)
[#60](#60)
* **commands:** checkhealth. Fixes
[#29](#29)
([245bb87](245bb87))
* deprecation warnings on 0.11
([c6e2d96](c6e2d96))
* **deprecation:** remove use of deprecated API functions
([#59](#59))
([983a93b](983a93b))
* flatten
([cdbd1f2](cdbd1f2))
* **health:** remove deprecated API warnings
([#28](#28))
([9625a17](9625a17))
* **health:** remove nvim-treesitter dependency
([#44](#44))
([3374276](3374276))
* **json:** set `null` values to `nil`
([2f131d0](2f131d0))
* **lspconfig:** dont deepcopy the full config. Do settings only
([37a7205](37a7205))
* normalize paths. Fixes
[#33](#33)
([e0835bd](e0835bd))
* remove nickel_ls
([ca5246f](ca5246f))
* **util:** check that root_dir exists. Fixes
[#56](#56). Closes
[#51](#51)
([f9dcd17](f9dcd17))
* **util:** normalize paths returned by `Util.file_patterns`
([#35](#35))
([7c34c86](7c34c86))
* **volar:** volar schema
([#64](#64))
([4274159](4274159))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants