Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: update schema source #54

Closed
1 task done
tuanha168 opened this issue Feb 16, 2024 · 1 comment · Fixed by #63
Closed
1 task done

feature: update schema source #54

tuanha168 opened this issue Feb 16, 2024 · 1 comment · Fixed by #63
Labels
enhancement New feature or request stale

Comments

@tuanha168
Copy link

Did you check the docs?

  • I have read all the neoconf.nvim docs

Is your feature request related to a problem? Please describe.

The schema gist that Neoconf is using is no longer maintained, and some LSPs are already outdated (for example, Volar), and build steps no longer generate JSON files.

Describe the solution you'd like

Perhaps we should consider switching sources, as suggested by the original gist author? Link

Describe alternatives you've considered

Maintaining the old gist seems unlikely, as it would require a significant amount of effort

Additional context

No response

Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 6, 2024
@folke folke linked a pull request Jul 6, 2024 that will close this issue
folke added a commit that referenced this issue Jul 6, 2024
This fixes a few issues relating to the CI json schema generation.

- befcc1f fixes #60, and also fixes
several other servers that previously had an empty `properties` in the
schema. This happened because `c.properties` is a table, which means
`vim.list_extend` doesn't do anything. `properties` should also always
be an object and not an array, so `vim.empty_dict()` is now being used
to prevent outputting `[]` when `properties` is empty.
- 84e19f4 embeds `index.json` rather
than downloading it every time. As mentioned in #54, the gist is no
longer maintained, so there's no reason to download it anymore. In the
future this should probably be [sourced from
elsewhere](https://gist.github.com/williamboman/a01c3ce1884d4b57cc93422e7eae7702?permalink_comment_id=4689512).
- 2a911fd fixes the URL for Volar.
- 6dfd503 is just me running the build
step locally. If I shouldn't have done this I'm happy to revert it.

Fixes #52
Fixes #60

Co-authored-by: Folke Lemaitre <[email protected]>
@folke folke closed this as completed in #63 Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant