Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP-ization #1562

Open
wants to merge 94 commits into
base: master
Choose a base branch
from
Open

SP-ization #1562

wants to merge 94 commits into from

Conversation

Marsella8
Copy link
Contributor

@Marsella8 Marsella8 commented Dec 19, 2024

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

@Marsella8 Marsella8 requested a review from lockshaw December 19, 2024 17:09
Copy link
Contributor Author

@Marsella8 Marsella8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 78 files reviewed, 1 unresolved discussion (waiting on @lockshaw)


lib/utils/test/src/utils/graph/series_parallel/sp_ization/spanish_algo.cc line 23 at r1 (raw file):

TEST_SUITE(FF_TEST_SUITE) {
  TEST_CASE("spanish_algo - subcomponents") {
    SUBCASE("add_dummy_nodes") {

how should I test graphs where nodes are added? Here I check for some properties but it's obviously non-exhaustive

@Marsella8 Marsella8 mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants