Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Library #1521

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

Marsella8
Copy link
Contributor

@Marsella8 Marsella8 commented Oct 10, 2024

Description of changes:

Extending testing functionality for graph library
Bug fixing
General clean up

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

This change is Reviewable

@Marsella8 Marsella8 requested a review from lockshaw October 10, 2024 04:25
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 72 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (1d5140d) to head (8564b8b).

Files with missing lines Patch % Lines
.../undirected/algorithms/get_connected_components.cc 0.00% 41 Missing ⚠️
...h/series_parallel/series_parallel_decomposition.cc 66.66% 12 Missing ⚠️
.../utils/graph/instances/hashmap_undirected_graph.cc 37.50% 10 Missing ⚠️
lib/utils/src/utils/graph/algorithms.cc 0.00% 3 Missing ⚠️
.../graph/instances/unordered_set_undirected_graph.cc 0.00% 2 Missing ⚠️
...rc/utils/graph/undirected/undirected_edge_query.cc 0.00% 2 Missing ⚠️
...aph/undirected/algorithms/get_neighboring_nodes.cc 0.00% 1 Missing ⚠️
...tils/src/utils/graph/undirected/undirected_edge.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           repo-refactor    #1521      +/-   ##
=================================================
+ Coverage          78.16%   79.05%   +0.89%     
=================================================
  Files                860      873      +13     
  Lines              27994    28703     +709     
  Branches             770      772       +2     
=================================================
+ Hits               21881    22691     +810     
+ Misses              6113     6012     -101     
Flag Coverage Δ
unittests 79.05% <89.47%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/utils/include/utils/containers/find.h 100.00% <100.00%> (ø)
...nclude/utils/graph/dataflow_graph/dataflow_graph.h 44.44% <ø> (-5.56%) ⬇️
lib/utils/include/utils/graph/digraph/digraph.h 100.00% <ø> (ø)
...b/utils/include/utils/graph/digraph/digraph_view.h 100.00% <ø> (ø)
...ls/include/utils/graph/multidigraph/multidigraph.h 100.00% <ø> (ø)
lib/utils/include/utils/graph/node/graph_view.h 100.00% <ø> (ø)
.../include/utils/graph/undirected/undirected_graph.h 100.00% <ø> (ø)
...ude/utils/graph/undirected/undirected_graph_view.h 100.00% <ø> (+20.00%) ⬆️
...ries_parallel/get_series_parallel_decomposition.cc 98.14% <100.00%> (-1.86%) ⬇️
.../utils/graph/series_parallel/parallel_reduction.cc 100.00% <100.00%> (ø)
... and 21 more

... and 123 files with indirect coverage changes

@Marsella8 Marsella8 marked this pull request as ready for review October 18, 2024 22:02
@lockshaw lockshaw changed the base branch from repo-refactor to master December 16, 2024 08:37
Copy link
Contributor Author

@Marsella8 Marsella8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 41 files reviewed, 1 unresolved discussion (waiting on @lockshaw)


lib/utils/src/utils/graph/series_parallel/series_parallel_decomposition.cc line 82 at r2 (raw file):

}

bool is_empty(Node const &node) {

borrowed from #1562, will fix them there if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant