Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: Don't fail requests with unsupported properties #1303

Closed
wants to merge 9 commits into from
Closed

notification: Don't fail requests with unsupported properties #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6e2f90a
tests/notification: Check result in notification add callback
jsparber Feb 29, 2024
e8875a2
tests/notification: Report backend errors
jsparber Apr 5, 2024
13f78fa
tests/notification: Remove redundant code
jsparber Mar 22, 2024
69152dd
notification: Don't fail requests with unsupported properties
jsparber Jan 17, 2024
0dcec82
test: Implement tests for notification icons
jsparber Feb 27, 2024
a16aee0
icon-validator: Allow custom path for icon validator via env
jsparber Apr 4, 2024
3482e33
utils: Print error log when icon-validator fails to validate a image
jsparber Apr 4, 2024
a66d939
CI: Fix running icon-validator
jsparber Apr 4, 2024
e66041b
validate-icon: Don't log command ever
jsparber Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
docker run --name $BUILD_CONTAINER \
--tty --device /dev/fuse --cap-add SYS_ADMIN \
--security-opt apparmor:unconfined \
--privileged \
-v $(pwd):/src \
-e DEBIAN_FRONTEND \
-e DEBCONF_NONINTERACTIVE_SEEN=true \
Expand All @@ -60,6 +61,8 @@ jobs:
libfontconfig1-dev \
libfuse3-dev \
libgdk-pixbuf-2.0-dev \
librsvg2-2 \
librsvg2-common \
libgeoclue-2-dev \
libglib2.0-dev \
libjson-glib-dev \
Expand Down
3 changes: 2 additions & 1 deletion src/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ if bwrap.found()
validate_icon_c_args += '-DHELPER="@0@"'.format(bwrap.full_path())
endif

executable(

xdp_validate_icon = executable(
'xdg-desktop-portal-validate-icon',
'validate-icon.c',
dependencies: [gdk_pixbuf_dep],
Expand Down
Loading
Loading