Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: Don't fail requests with unsupported properties #1303

Closed
wants to merge 9 commits into from

Commits on Apr 4, 2024

  1. tests/notification: Check result in notification add callback

    Adding a notification may fail, instead of waiting for the timeout
    we can check the result we get in the callback.
    jsparber committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6e2f90a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. tests/notification: Report backend errors

    For debugging it's important that the backend doesn't just crash without
    telling the reason. It would be even nicer if the test would fail
    immediately instead of hitting the timeout, but that' currently not
    possible since the client doesn't know whether the backend failed.
    jsparber committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e8875a2 View commit details
    Browse the repository at this point in the history
  2. tests/notification: Remove redundant code

    We can reuse most of the test setup for all tests. This will make it
    easier to test more properties.
    jsparber committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    13f78fa View commit details
    Browse the repository at this point in the history
  3. notification: Don't fail requests with unsupported properties

    This filters unsupported properties from a notification request without
    failing it. This allows backwards compatibility after adding new
    properties. This should had been the case from the beginning so that we
    don't have to break API when extending the notification interface. See
    [1].
    
    [1] https://dbus.freedesktop.org/doc/dbus-api-design.html#extensibility
    jsparber committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    69152dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0dcec82 View commit details
    Browse the repository at this point in the history
  5. icon-validator: Allow custom path for icon validator via env

    This allows setting a custom path for the icon validator, especially
    useful when testing without installing.
    jsparber committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a16aee0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3482e33 View commit details
    Browse the repository at this point in the history
  7. CI: Fix running icon-validator

    The sandbox for the icon-validator needs a privileged container.
    And it needs librsvg to be able to validate SVGs.
    jsparber committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a66d939 View commit details
    Browse the repository at this point in the history
  8. validate-icon: Don't log command ever

    If debug messages are turned on the output of validate-icon isn't a
    valid key file since it contains log output as well.
    jsparber committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e66041b View commit details
    Browse the repository at this point in the history