[FIX] tighten the forward tests according to observed error wrt array size #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also removed the float32 version of the test for now. the error will definitely be larger there but there is at least currently no reason to believe that float32 will not work if float64 does |
WardBrian
reviewed
Oct 5, 2023
tests/test_1d/test_forward_1d.py
Outdated
| assert l_2_error < 7.5e-4 * N ** 1.1 | ||
| assert l_1_error < 5e-4 * N ** 1.6 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("targets", cases) | ||
| def test_1d_t2_forward_CPU(targets: torch.Tensor): |
There was a problem hiding this comment.
I think you missed type2 in this file
Agreed. There's a narrow line between testing the pytorch wrapper and testing FINUFFT itself |
WardBrian
approved these changes
Oct 5, 2023
|
This was included in #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotted errors as a function of N and updated the tests to make them as tight as possible