Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG fft correctness checks are vacuous #66

Closed
eickenberg opened this issue Oct 4, 2023 · 0 comments · Fixed by #64
Closed

BUG fft correctness checks are vacuous #66

eickenberg opened this issue Oct 4, 2023 · 0 comments · Fixed by #64

Comments

@eickenberg
Copy link
Collaborator

assert abs((finufft_out - against_torch).sum()) / (N**3) == pytest.approx(
        0, abs=1e-6

sum is inside the abs, and we are potentially dividing by 1 billion, both of these make the tests very weak with no guarantee of correctness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant