Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if no relays are configured #320

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Fail if no relays are configured #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04a0e5
Fail if no relays are configured
ferranbt Dec 31, 2024
b5b550c
Relays are also necessary on dry_run
ferranbt Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/rbuilder/src/live_builder/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ impl L1Config {
);

let relays = self.create_relays()?;
if relays.is_empty() {
eyre::bail!("No relays provided");
}
Comment on lines +281 to +283
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

op-rbuilder doesn't require relays. With all the assumptions the new_builder method makes about L1 specific config, maybe it should be renamed new_l1_builder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, my goal is to end up with a chain-agnostic core block building and then make LiveBuilder the specific instance that "wires" that block builder for the Ethereum L1 chain.


let sink_factory: Box<dyn BuilderSinkFactory> = Box::new(RelaySubmitSinkFactory::new(
submission_config,
relays.clone(),
Expand Down
Loading