Fail if no relays are configured #320
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
dvush,
ZanCorDX and
liamaharon
as code owners
Benchmark results for
|
| Date (UTC) | 2024-12-31T15:29:52+00:00 |
| Commit | b5b550ccbb8db477ef889f78d34386150b40171d |
| Base SHA | 821a88c160c1cc7f8c2a64085b63988f536e5147 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_empty_account | 3.23% | Performance has degraded. |
|
Why do you check for |
|
True, I have to do only |
liamaharon
approved these changes
Jan 2, 2025
Comment on lines
+281
to
+283
| if relays.is_empty() { | ||
| eyre::bail!("No relays provided"); | ||
| } |
There was a problem hiding this comment.
op-rbuilder doesn't require relays. With all the assumptions the new_builder method makes about L1 specific config, maybe it should be renamed new_l1_builder?
There was a problem hiding this comment.
Agree, my goal is to end up with a chain-agnostic core block building and then make LiveBuilder the specific instance that "wires" that block builder for the Ethereum L1 chain.
ZanCorDX
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #304
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test