This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Install dependencies if missing. Fix #169. #172
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #169. It does so by doing a few things. It creates the functions getOS1, getPackageManager (which also sets the package dependencies lists), and installPackages (a basic wrapper for our variables). Further, it modifies check_cmds and check_libs to install packages if missing.
It also simplifies the dependency checks and moves them further down the installer's process. This is the only way to keep the script from having to do this twice (i.e., once for base dependencies, once for version specific dependencies). To help with this, it also creates a new logosSetup function. Also, remember that the initial checks of the script are for a dialog program and for whether the system is running a GUI environment.
Finally, it makes the AppImage install the default/recommended method, as we know it works on all system's without having to deal with the wine staging requirement, and the AppImage install is the only option that always appears on the list as is. All this to say, it is our "stable" install.
TODO
yes
flagsFootnotes
This function is not heavily used at the moment but available just in case. Some distros will change a package name though it uses the same package manager and we may need to utilize this. Right now its only purpose is for installing libfuse3 on Debian-based systems. ↩