-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference Lines, Reference Points + Summary Output, Timeseries Output #56
Conversation
reference points geom reflines, refpoints output tests for reflines, refpoints
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thomas and team, nice work. First time I've interacted with the code, but it's easy to use both in python and the CLI. It seems the new functionality isn't added to the CLI yet though? I didn't check the timseries stuff yet, fyi but approving assuming you've qc'd on your side. Note that the readme on main has some deprecated methods illustrated, I think.
RasGeomHdf
:reference_lines
reference_points
RasPlanHdf
Dataset
:RasPlanHdf.reference_lines_timeseries_output
RasPlanHdf.reference_points_timeseries_output
RasGeomHdf._get_polylines
method to extract generic polyline geometry from the RAS HDF format. This is now used to extract geometry for reference lines, cross-sections, river reaches, and structures.Example usage
Reference Lines/Points Names, Geometry
Summary output data
Timeseries output data