Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GeoPandas 1.0 #58

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Upgrade to GeoPandas 1.0 #58

merged 4 commits into from
Jul 13, 2024

Conversation

thwllms
Copy link
Contributor

@thwllms thwllms commented Jul 11, 2024

Merge AFTER #56. Change base to main.

GeoPandas 1.0.0 and 1.0.1 were released in late June / early July 2024. Most of our code is unaffected, but there was a major dependency change at version 1.0.0 -- GeoPandas now relies on pyogrio for file input/output by default instead of Fiona (though Fiona is still supported).
https://geopandas.org/en/stable/docs/changelog.html#version-1-0-0-june-24-2024

  • Includes changes to accommodate both pyogrio and Fiona for writing RAS data.
  • Specifies the Fiona engine for some unit tests due to minor differences between data written by pyogrio and Fiona.

@thwllms thwllms linked an issue Jul 11, 2024 that may be closed by this pull request
Copy link

@wolfpack-daragon wolfpack-daragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. If I remember correctly pyogrio will be used by default if installed?

Base automatically changed from feature/reference-lines-points to main July 13, 2024 01:28
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/cli.py 93.75% <100.00%> (+5.43%) ⬆️

@thwllms
Copy link
Contributor Author

thwllms commented Jul 13, 2024

Nice addition. If I remember correctly pyogrio will be used by default if installed?

@wolfpack-daragon yeah, pyogrio will be installed by default with GeoPandas 1.0, but Fiona is now optional. Likewise, rashdf from here will install with pyogrio but can optionally use Fiona if it's installed.

@thwllms thwllms changed the title WIP: Upgrade to GeoPandas 1.0 Upgrade to GeoPandas 1.0 Jul 13, 2024
@thwllms thwllms merged commit 000829f into main Jul 13, 2024
5 checks passed
@thwllms thwllms deleted the feature/geopandas-1.0 branch July 13, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade GeoPandas to 1.0
2 participants