Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Validation Helpers #467

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Consolidate Validation Helpers #467

merged 10 commits into from
Dec 5, 2024

Conversation

henryfauna
Copy link
Contributor

@henryfauna henryfauna commented Dec 4, 2024

Ticket(s): FE-6162

Problem

We have a validateDatabaseOrSecret helper and a validateSecretOrDatabase helper. We don't need both.

Solution

Consolidate onto just one of these.

Result

We have one place where we tell users they need to specify --database, --secret or --local for commands that need to talk to a specific database, eg database create or database delete.

@henryfauna henryfauna changed the base branch from main to v3 December 4, 2024 22:23
@henryfauna henryfauna marked this pull request as ready for review December 5, 2024 00:26
@henryfauna henryfauna requested a review from a team as a code owner December 5, 2024 00:26
@ecooper ecooper merged commit 4165d88 into v3 Dec 5, 2024
4 checks passed
@ecooper ecooper deleted the FE-6162 branch December 5, 2024 17:18
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants