Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE-6127] Delete Database #437

Merged
merged 5 commits into from
Nov 26, 2024
Merged

[FE-6127] Delete Database #437

merged 5 commits into from
Nov 26, 2024

Conversation

henryfauna
Copy link
Contributor

@henryfauna henryfauna commented Nov 25, 2024

Ticket(s): FE-6127

Problem

We do not support the fauna database delete command yet.

Solution

  • Wire up this command following the patterns established by fauna database create.
  • Ensure we handle some of the common error scenarios a user might run into. For example, the database does not exist.

Result

You can delete a database using fauna database delete --name <db_name> --secret <parent_db_secret>

Out of Scope

Authenticating with the credentials vended by fauna login.

Testing

Added units to ensure we handle args correctly and call fauna/handle errors correctly.

Screenshot 2024-11-25 at 2 20 57 PM

@henryfauna henryfauna marked this pull request as ready for review November 25, 2024 22:25
@henryfauna henryfauna requested a review from a team as a code owner November 25, 2024 22:25
@henryfauna henryfauna merged commit 5bb7f4a into v3 Nov 26, 2024
4 checks passed
@henryfauna henryfauna deleted the delete-database branch November 26, 2024 15:36
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants