Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated assert for layer checkpointing. #349

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Remove outdated assert for layer checkpointing. #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab95eeb
Remove outdated assert for layer checkpointing.
escfrya Nov 10, 2023
b31ad05
Merge branch 'facebookresearch:main' into patch-2
escfrya Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion audiocraft/modules/transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,6 @@ def __init__(self, d_model: int, num_heads: int, num_layers: int, dim_feedforwar
# see audiocraft/optim/fsdp.py, magic signal to indicate this requires fixing the
# backward hook inside of FSDP...
layer._magma_checkpointed = True # type: ignore
assert layer.layer_drop == 0., "Need further checking" # type: ignore

def _apply_layer(self, layer, *args, **kwargs):
method = self.checkpointing
Expand Down
Loading