Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated assert for layer checkpointing. #349

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Remove outdated assert for layer checkpointing. #349

merged 2 commits into from
Nov 22, 2023

Conversation

escfrya
Copy link
Contributor

@escfrya escfrya commented Nov 10, 2023

Looks like this assert checks abandoned experimental layer_drop param, which not exists anymore.

@escfrya
Remove outdated assert for layer checkpointing.
ab95eeb 
Looks like this assert checks abandoned experimental `layer_drop` param, which not exists anymore.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2023
JadeCopet
JadeCopet approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@JadeCopet
Copy link
Contributor

Can you make sure you have the latest changes from main so that the CI passes? Thanks

@escfrya
Copy link
Contributor Author

escfrya commented Nov 21, 2023

Can you make sure you have the latest changes from main so that the CI passes? Thanks

Done

@JadeCopet
Copy link
Contributor

Thanks!

@JadeCopet JadeCopet merged commit c65e9be into facebookresearch:main Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadeCopet JadeCopet JadeCopet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@escfrya @JadeCopet @facebook-github-bot