[lexical] Bug Fix: Missing variables and functions in Flow file #6866

lytion · 2024-11-25T12:48:41Z

Missing variables and functions in Flow file.

Description

I found that some variables and function are missing in the lexical Flow file, here is a suggested fix.

Missing variables and functions in Flow file.

facebook-github-bot · 2024-11-25T12:48:46Z

Hi @lytion!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

vercel · 2024-11-25T12:48:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 3:46pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 3:46pm

github-actions · 2024-11-25T12:50:27Z

size-limit report 📦

Path	Size
lexical - cjs	31.29 KB (0%)
lexical - esm	31.11 KB (0%)
@lexical/rich-text - cjs	40.34 KB (0%)
@lexical/rich-text - esm	33.04 KB (0%)
@lexical/plain-text - cjs	38.88 KB (0%)
@lexical/plain-text - esm	30.3 KB (0%)
@lexical/react - cjs	42.12 KB (0%)
@lexical/react - esm	34.29 KB (0%)

facebook-github-bot · 2024-11-25T13:06:35Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

potatowagon · 2024-11-26T00:30:16Z

packages/lexical/flow/Lexical.js.flow

@@ -256,6 +256,7 @@ export type EditorThemeClasses = {
    ulDepth?: Array<EditorThemeClassName>,


when i run flow on these changes i get this error, other files may need updating

[[email protected] /data/sandcastle/boxes/www (c0d10ff15)]$ flow Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/Lexical.js.flow:469:22 Cannot implement BaseSelection [1] with NodeSelection because property _cachedNodes is missing in NodeSelection [2] but exists in BaseSelection [1]. [prop-missing] 466│ setCachedNodes(nodes: null | Array<LexicalNode>): void; 467│ } 468│ [2][1] 469│ declare export class NodeSelection implements BaseSelection { 470│ _nodes: Set<NodeKey>; 471│ dirty: boolean; 472│ constructor(objects: Set<NodeKey>): void; Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/Lexical.js.flow:469:22 Cannot implement BaseSelection [1] with NodeSelection because property getStartEndPoints is missing in NodeSelection [2] but exists in BaseSelection [1]. [prop-missing] 466│ setCachedNodes(nodes: null | Array<LexicalNode>): void; 467│ } 468│ [2][1] 469│ declare export class NodeSelection implements BaseSelection { 470│ _nodes: Set<NodeKey>; 471│ dirty: boolean; 472│ constructor(objects: Set<NodeKey>): void; Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/Lexical.js.flow:469:22 Cannot implement BaseSelection [1] with NodeSelection because property isBackward is missing in NodeSelection [2] but exists in BaseSelection [1]. [prop-missing] 466│ setCachedNodes(nodes: null | Array<LexicalNode>): void; 467│ } 468│ [2][1] 469│ declare export class NodeSelection implements BaseSelection { 470│ _nodes: Set<NodeKey>; 471│ dirty: boolean; 472│ constructor(objects: Set<NodeKey>): void; Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/Lexical.js.flow:469:22 Cannot implement BaseSelection [1] with NodeSelection because property isCollapsed is missing in NodeSelection [2] but exists in BaseSelection [1]. [prop-missing] 466│ setCachedNodes(nodes: null | Array<LexicalNode>): void; 467│ } 468│ [2][1] 469│ declare export class NodeSelection implements BaseSelection { 470│ _nodes: Set<NodeKey>; 471│ dirty: boolean; 472│ constructor(objects: Set<NodeKey>): void; Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/Lexical.js.flow:493:22 Cannot implement BaseSelection [1] with RangeSelection because property _cachedNodes is missing in RangeSelection [2] but exists in BaseSelection [1]. [prop-missing] 490│ x: ?mixed, 491│ ): x is NodeSelection; 492│ [2][1] 493│ declare export class RangeSelection implements BaseSelection { 494│ anchor: PointType; 495│ focus: PointType; 496│ dirty: boolean; Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/Lexical.js.flow:493:22 Cannot implement BaseSelection [1] with RangeSelection because property getStartEndPoints is missing in RangeSelection [2] but exists in BaseSelection [1]. [prop-missing] 490│ x: ?mixed, 491│ ): x is NodeSelection; 492│ [2][1] 493│ declare export class RangeSelection implements BaseSelection { 494│ anchor: PointType; 495│ focus: PointType; 496│ dirty: boolean; Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ html/shared/lexical/LexicalTable.js.flow:323:22 Cannot implement BaseSelection [1] with TableSelection because property _cachedNodes is missing in TableSelection [2] but exists in BaseSelection [1]. [prop-missing] 320│ toX: number, 321│ toY: number, 322│ }; [2][1] 323│ declare export class TableSelection implements BaseSelection { 324│ tableKey: NodeKey; 325│ anchor: PointType; 326│ focus: PointType; Found 7 errors The Flow server is currently in lazy mode and is only checking 585463/1396902 files. To learn more, visit flow.org/en/docs/lang/lazy-modes

That is weird, I can see these functions in https://lexical.dev/docs/api/interfaces/lexical.BaseSelection
I directly added this on my project and everything was fine but maybe I'm missing out something. I will try on the repo when I have some time

etrepum · 2024-11-26T01:04:03Z

packages/lexical/flow/Lexical.js.flow

@@ -446,13 +447,17 @@ declare export function $isBlockElementNode(
 ): node is ElementNode;

 export interface BaseSelection {
-  clone(): BaseSelection;
+  _cachedNodes: Array<LexicalNode> | null;


I don't think this should be here. It's not a public interface

agree, and its breaking other apis too

etrepum · 2024-11-26T01:05:05Z

packages/lexical/flow/Lexical.js.flow

@@ -528,6 +533,7 @@ declare export class RangeSelection implements BaseSelection {
 }
 export type TextPoint = TextPointType;
 type TextPointType = {
+  _selection: BaseSelection,


_selection isn't part of the public interface for these point types either

My bad, I must have used it incorrectly. I was trying to access rangeSelection.anchor._selection.getStartEndPoints() but I guess I should have used rangeSelection.getStartEndPoints().

lytion · 2024-11-26T08:58:51Z

I removed all private variables and added missing functions in RangeSelection that I found on https://lexical.dev/docs/api/classes/lexical.RangeSelection

potatowagon · 2024-11-26T10:21:20Z

https://github.com/facebook/lexical/actions/runs/12027063755/job/33527314547?pr=6866

npm run ci-check which runs flow has errors,

Cannot implement BaseSelection [1] with NodeSelection because property getStartEndPoints is missing in
NodeSelection [2] but exists in BaseSelection [1]. [prop-missing]

lytion · 2024-12-18T15:46:23Z

Will create a new PR without using the github editor system which I'm not used to of

Update Lexical.js.flow

df24486

Missing variables and functions in Flow file.

lytion requested review from zurfyx, fantactuka, acywatson, Fetz, ivailop7, Sahejkm and potatowagon as code owners November 25, 2024 12:48

vercel bot deployed to Preview – lexical November 25, 2024 12:49 View deployment

vercel bot deployed to Preview – lexical-playground November 25, 2024 12:49 View deployment

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2024

potatowagon reviewed Nov 26, 2024

View reviewed changes

etrepum reviewed Nov 26, 2024

View reviewed changes

Remove private types and fix RangeSelection

802af27

vercel bot deployed to Preview – lexical November 26, 2024 08:56 View deployment

vercel bot deployed to Preview – lexical-playground November 26, 2024 08:56 View deployment

Fix error from ci-check

2858940

lytion closed this Dec 18, 2024

vercel bot deployed to Preview – lexical-playground December 18, 2024 15:46 View deployment

vercel bot deployed to Preview – lexical December 18, 2024 15:46 View deployment

lytion mentioned this pull request Dec 18, 2024

[lexical] Bug Fix: Flow is missing some variables and functions #6977

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lexical] Bug Fix: Missing variables and functions in Flow file #6866

[lexical] Bug Fix: Missing variables and functions in Flow file #6866

lytion commented Nov 25, 2024

facebook-github-bot commented Nov 25, 2024

vercel bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

facebook-github-bot commented Nov 25, 2024

potatowagon Nov 26, 2024

lytion Nov 26, 2024

etrepum Nov 26, 2024

potatowagon Nov 26, 2024

etrepum Nov 26, 2024

lytion Nov 26, 2024

lytion commented Nov 26, 2024

potatowagon commented Nov 26, 2024

lytion commented Dec 18, 2024

		@@ -256,6 +256,7 @@ export type EditorThemeClasses = {
		ulDepth?: Array<EditorThemeClassName>,

[lexical] Bug Fix: Missing variables and functions in Flow file #6866

[lexical] Bug Fix: Missing variables and functions in Flow file #6866

Conversation

lytion commented Nov 25, 2024

Description

facebook-github-bot commented Nov 25, 2024

Action Required

Process

vercel bot commented Nov 25, 2024 • edited Loading

github-actions bot commented Nov 25, 2024 • edited Loading

size-limit report 📦

facebook-github-bot commented Nov 25, 2024

potatowagon Nov 26, 2024

Choose a reason for hiding this comment

lytion Nov 26, 2024

Choose a reason for hiding this comment

etrepum Nov 26, 2024

Choose a reason for hiding this comment

potatowagon Nov 26, 2024

Choose a reason for hiding this comment

etrepum Nov 26, 2024

Choose a reason for hiding this comment

lytion Nov 26, 2024

Choose a reason for hiding this comment

lytion commented Nov 26, 2024

potatowagon commented Nov 26, 2024

lytion commented Dec 18, 2024

vercel bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading