[lexical] Bug Fix: Flow is missing some variables and functions #6977
Conversation
- EditorThemeClasses - BaseSelection - NodeSelection - RangeSelection
lytion
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
| isBackward(): boolean; | ||
| isCollapsed(): boolean; |
There was a problem hiding this comment.
Is it useful to add this here, when it already declares that BaseSelection is implemented?
There was a problem hiding this comment.
If I remove those 2 declarations, npm run ci-check return this error
Cannot implement BaseSelection [1] with NodeSelection because property isCollapsed is missing in NodeSelection [2] but exists in BaseSelection [1]. [prop-missing]
| @@ -530,6 +538,8 @@ declare export class RangeSelection implements BaseSelection { | |||
| insertNodes(nodes: Array<LexicalNode>): void; | |||
| getCachedNodes(): null | Array<LexicalNode>; | |||
| setCachedNodes(nodes: null | Array<LexicalNode>): void; | |||
| forwardDeletion(anchor: PointType, anchorNode: ElementNode | TextNode, isBackward: boolean): boolean; | |||
| getStartEndPoints(): null | [PointType, PointType]; | |||
There was a problem hiding this comment.
This also looks to be the same as BaseSelection
There was a problem hiding this comment.
Same as the other comment, if I remove those 2 declarations, npm run ci-check return this error
Cannot implement BaseSelection [1] with RangeSelection because property getStartEndPoints is missing in
RangeSelection [2] but exists in BaseSelection [1]. [prop-missing]
| dirty: boolean; | ||
| clone(): BaseSelection; |
There was a problem hiding this comment.
curious about the use cases outside of meta for these added api
just a nit, rearranging clone to be after dirty would break the unenforced abc sorting for props
other then that lgtm
This comment was marked as spam.
This comment was marked as spam.
Description
Some variables and function are missing in flow file.
Here are classes affected:
This is the following of #6866