[lexical-playground] Bug Fix: Fix tests #6228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderReznik
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
potatowagon
approved these changes
May 31, 2024
|
thanks for the quick fix |
size-limit report 📦
|
|
I think we should probably add extended-tests to #6227 first so that the windows e2e suite runs correctly again, update this PR with main after that lands to bring in the fix, and then add the extended-tests label to this PR so we can see the full suite running and confirm that the fix works cross-platform |
StyleT
approved these changes
May 31, 2024
|
Based on the mac failures I don't think this is resolved just yet, it appears to be slight differences in size metrics (height) https://github.com/facebook/lexical/actions/runs/9322094913/job/25662413222?pr=6228 |
|
Rejected in favor of #6224 Pls fix tests and re-submit your changes. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing tests from #6200
I have them passing locally in WSL so it's a bit of a guess, but I'm unifying how
clickis made