Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 1st causing some new added tests fail in collab mode and webkit mode #6224

Merged
merged 1 commit into from
May 31, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 31, 2024

NOTE

Breaking tests are passing after revert but some test run builds are failing due to vite config error

> > vite build
failed to load config from D:\a\lexical\lexical\packages\lexical-playground\vite.config.ts
error during build:
Error: Missing package with directory name 'shared'

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 7:32pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 7:32pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2024
@Sahejkm Sahejkm added the extended-tests Run extended e2e tests on a PR label May 31, 2024
Copy link

github-actions bot commented May 31, 2024

size-limit report 📦

Path Size
lexical - cjs 23.97 KB (0%)
lexical - esm 23.96 KB (0%)
@lexical/rich-text - cjs 34.66 KB (0%)
@lexical/rich-text - esm 23.95 KB (0%)
@lexical/plain-text - cjs 34.65 KB (0%)
@lexical/plain-text - esm 225 B (0%)
@lexical/react - cjs 149.31 KB (0%)
@lexical/react - esm 82.64 KB (0%)

@Sahejkm Sahejkm marked this pull request as ready for review May 31, 2024 15:53
@potatowagon potatowagon self-requested a review May 31, 2024 16:04
@potatowagon
Copy link
Contributor

maybe it would be faster to raise a pr fixing the test? lemme see if i can raise something tonight

Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR6228 fixes the test so we can close this

@etrepum
Copy link
Collaborator

etrepum commented May 31, 2024

I think there are still test failures in #6228 but we would want to check this after #6227 (or merge that code in here) to make sure that the combination covers all of the test regressions

@StyleT
Copy link
Contributor

StyleT commented May 31, 2024

PR6228 fixes the test so we can close this

#6228 still fails tests after rebase on top of #6227 - merging this

@StyleT StyleT enabled auto-merge May 31, 2024 21:44
@StyleT StyleT requested a review from potatowagon May 31, 2024 21:45
@StyleT StyleT dismissed potatowagon’s stale review May 31, 2024 21:45

#6228 still fails tests after rebase on top of #6227 - merging this

@StyleT StyleT added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit fc1285c May 31, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants