Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Fix meta sync build failing due to recent changes in LexicalErrorBoundary.tsx #6140

Merged
merged 1 commit into from
May 20, 2024
Merged

[Lexical] Fix meta sync build failing due to recent changes in LexicalErrorBoundary.tsx #6140

merged 1 commit into from
May 20, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 20, 2024 •
edited
Loading

import * as React from 'react';

from LexicalErrorBoundary.tsx

  • but in generated file LexicalErrorBoundary.dev.js / LexicalErrorBoundary.prod.js this import was needed,
  • would need further investigation whats going wrong, but this should fix the WWW sync causing some e2e tests to fail with the issue replicable on trying the steps manually as well
Screenshot 2024-05-20 at 12 19 39 PM

@vercel Vercel
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 4:05am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 4:05am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.91 KB (0%) 479 ms (0%) 74 ms (+237.32% 🔺) 552 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.6 KB (0%) 693 ms (0%) 160 ms (+137.18% 🔺) 852 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 162 ms (+153.33% 🔺) 852 ms

@Sahejkm Sahejkm marked this pull request as ready for review May 20, 2024 04:08
@Sahejkm Sahejkm changed the title [Lexical] Fix sync build related to changes in LexicalErrorBoundary.tsx [Lexical] Fix sync build failing due to recent changes in LexicalErrorBoundary.tsx May 20, 2024
@Sahejkm Sahejkm changed the title [Lexical] Fix sync build failing due to recent changes in LexicalErrorBoundary.tsx [Lexical] Fix meta sync build failing due to recent changes in LexicalErrorBoundary.tsx May 20, 2024
freddymeta
freddymeta approved these changes May 20, 2024
View reviewed changes
Copy link

@freddymeta freddymeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the extended-tests Run extended e2e tests on a PR label May 20, 2024
potatowagon
potatowagon approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Sahejkm Sahejkm added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 0bdd6fb May 20, 2024
41 of 43 checks passed
@etrepum etrepum mentioned this pull request May 20, 2024
Merged
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddymeta freddymeta freddymeta approved these changes

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahejkm @potatowagon @freddymeta @facebook-github-bot