-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-react] Bug Fix: Use automatic jsx runtime with react/jsx-runtime -> react alias in www #6143
Conversation
…time -> react alias in www
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/cc @Sahejkm |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry about this, i am asking the OSS support for the next steps. Looks like "pull_request_review" event was triggered , i missed while reviewing Nicolas added "pull_request_review" back, but this doesn't help with PRs from fork again :( i have listed the problem as below: PROBLEM WE ARE TRYING TO SOLVE CURRENT APPROACH NEXT STEPS TO FIX FAILURE IN CURRENT APPROACH pull_request_target : this action gives the github workflow actions permissions for read/write from forked PR. But this action doesn't help us as we want to trigger this action on "Approval" , so only option we have is "pull_request_review" which doesn't have permissions to add Labels on PRs from forks |
Description
Changes www builds to use automatic jsx runtime with the react/jsx-runtime module aliased to react.
As far as I can tell react's index.fb.js is used as the module's entrypoint for fb builds and it includes the JSX runtime (Fragment is already present in the react module).
This should solve the problems that #6134 and #6140 are trying to work around in a more systematic and future-compatible way.
Test plan
Someone with access to intern will have to do a sync and make sure that this does indeed work.