[lexical-playground][TableCellResizer] Feature: Center the drag zone over the edge of the cell #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift the selection rectangles to the center of the edge, instead of being outside the cell. This makes for a more intuitive user experience as the user will try to select the edge, not the outside of the table cell.
apella
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ivailop7
changed the title
|
@ebads67 is this the final version we settled on? |
ivailop7
approved these changes
May 12, 2024
Yes, this is just centering the cell resizer drag zone. |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shift the selection rectangles to the center of the edge, instead of being outside the cell. This makes for a more intuitive user experience as the user will try to select the edge, not the outside of the table cell.
Test plan
Before
(briefly visualized the areas so that the change can be seen)
After
Insert relevant screenshots/recordings/automated-tests