Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Git Checks for running test.yml workflows and size.yml workflows are getting skipped for PRs #6074

Closed
Sahejkm opened this issue May 10, 2024 · 5 comments
Assignees
Labels
enhancement Improvement over existing feature

Comments

@Sahejkm
Copy link
Contributor

Sahejkm commented May 10, 2024

Recently the git checks from test.yml are flaky and getting skipped on PR updates few times
Example PR: https://github.com/facebook/lexical/pull/6056/checks

Could be various reasons as per https://stackoverflow.com/questions/77996177/how-can-i-handle-a-required-check-that-isnt-always-triggered

@Sahejkm Sahejkm added the enhancement Improvement over existing feature label May 10, 2024
@Sahejkm Sahejkm changed the title Feature: Git Checks for running test.yml workflows and size.yml workflows are getting skipped Feature: Git Checks for running test.yml workflows and size.yml workflows are getting skipped for PRs May 10, 2024
@etrepum
Copy link
Collaborator

etrepum commented May 10, 2024

I noticed this as well, it seemed to start around #6071 or #6056 - I don't believe that it has anything to do with the workflow configuration but also I haven't seen anything on https://www.githubstatus.com/ about this

@etrepum
Copy link
Collaborator

etrepum commented May 10, 2024

I think that the checks that are running are not workflow based at all, but are instead triggered by webhooks to other services

@etrepum
Copy link
Collaborator

etrepum commented May 10, 2024

I suspect that someone with a high enough access level on the repo or org has to tick some boxes or solve a billing issue to get workflows going again

@Sahejkm Sahejkm self-assigned this May 11, 2024
@ivailop7
Copy link
Collaborator

Gerard took care of it

@Sahejkm
Copy link
Contributor Author

Sahejkm commented May 13, 2024

think

  • still need this to move more tests from e2e to unit wherever possible, so that we don't face budget restraints in future,
  • Nicole / Bob / Acy are also helping in optimising the git workflows for future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement over existing feature
Projects
None yet
Development

No branches or pull requests

3 participants