-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EAK-504] Limited Parsys: add functionality to limit parsys-like components child component count #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ala-n
added
javascript
JavaScript code contribution
AEM
AEM-specific competencies are involved
labels
Jan 23, 2024
… APIs into single `policies` bundle
…, add blocked state)
ala-n
requested review from
smiakchilo,
liubou-masiuk,
dshovchko,
abarmina,
mhoroshko,
a team and
NastaLeo
January 24, 2024 02:02
NastaLeo
approved these changes
Jan 24, 2024
plugin/src/test/resources/handlers/common/maxChildren/simple/_cq_childEditConfig.xml
Outdated
Show resolved
Hide resolved
...n/src/test/resources/handlers/common/maxChildren/withAllowedChildren/_cq_childEditConfig.xml
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/policies/js/maxChildren.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/policies/js/maxChildren.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/policies/js/maxChildren.js
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/exadel/aem/toolkit/plugin/handlers/common/MaxChildrenHandler.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/exadel/aem/toolkit/plugin/handlers/common/MaxChildrenHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: alesun <[email protected]>
ala-n
force-pushed
the
feature/limited-parsys
branch
from
January 24, 2024 12:36
8a84456
to
1aefa8c
Compare
dshovchko
approved these changes
Jan 24, 2024
core/src/main/java/com/exadel/aem/toolkit/api/annotations/policies/MaxChildren.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/exadel/aem/toolkit/api/annotations/policies/PolicyTarget.java
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/policies/js/maxChildren.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/policies/js/maxChildren.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/policies/js/maxChildren.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/utils/js/utils.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-authoring-kit/utils/js/utils.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmytro Shovchko <[email protected]>
abarmina
approved these changes
Jan 25, 2024
liubou-masiuk
approved these changes
Jan 25, 2024
smiakchilo
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
core/src/main/java/com/exadel/aem/toolkit/api/annotations/policies/MaxChildren.java
Show resolved
Hide resolved
plugin/src/main/java/com/exadel/aem/toolkit/plugin/handlers/common/MaxChildrenHandler.java
Outdated
Show resolved
Hide resolved
ala-n
force-pushed
the
feature/limited-parsys
branch
from
January 29, 2024 19:25
646f961
to
a321900
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Final Scope:
A clientlib is provided to address the maximum children limit for containers (e.g., parsys) using a custom
cq:listener
or the design/policy property. The client library decorates theINSERT
action and monitors editable placeholders (e.g., newpar). When the limit is reached, theINSERT
action is hidden and inactive, placeholders are disabled, and an additionaldata-max-children-marker
attribute is applied to placeholders for visual appearance customization (such as a custom red message and hover state, provided out-of-the-box).In addition to the JS API, the EAK annotation set has been expanded with the
@MaxChildren
annotation to declare the maximum children resolvercq:listener
using component Java metadata.Notes for the Current PR:
policy-management
and the newmax-children
functionality have been consolidated into a singleeak.policy
client library/module, as they will reuse the same logic for rule filtering.Closes: #504