Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix GAMS by fixing TIMES_model path, NZ file structure #247

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

olejandro
Copy link
Member

No description provided.

@olejandro
Copy link
Member Author

@siddharth-krishna here is what this branch is about:

  • in 58ff3ef GAMS runs
  • in 7cc8a8b (identical with main) GAMS fails
    Both use the same GAMS version and license.
    I suspect, the reason GAMS fails after refactoring is a change in paths (so GAMS is unable to find scenario.run).
    E.g. in /home/runner/work/xl2times/xl2times/xl2times/benchmarks/out/DemoS_001-all/scenario.run, the out subfolder looks new to me...

@siddharth-krishna
Copy link
Collaborator

Thanks, Olex, this is great detective work! (I tried to look for a last commit where gams ran successfully and couldn't find one, I must have missed something...) Looks like my CI refactor moved the TIMES_model path to inside the xl2times root folder, but this is something that probably makes sense for local developers (to keep all xl2times-related stuff within the root folder) so I've modified the CI to also use that path. This fixes gams for Demos & Ireland 🚀

We still have some errors on NZ:

  • One issue is because we expect a file ts.dd in the ground truth, but NZ has it as e.g. TIMES-NZ-GAMS/times_scenarios/kea-v2_1_3/kea-v2_1_3_ts.dd. What's a nice way to resolve this, should we add a field to benchmarks.yml specifying the name of the TS file?
  • The other was because there was a redundant .dd extension in benchmarks.yml for the NZ models, I've fixed this. Now there are a whole host of Domain violation errors, but these can be resolved by fixing the TS path above. Fixing that leads to one more issue:
  • There is no milestonyr.dd file in NZ ground truth, they have it manually specified in e.g. kea-v2_1_3.run. Adding this definition makes gams run without errors.

Perhaps we can take advantage of your prescience and add a ts.dd and milestonyr.dd to your branch of the NZ model repo? :)

@olejandro olejandro marked this pull request as ready for review November 18, 2024 16:34
@olejandro
Copy link
Member Author

@siddharth-krishna seems ready now!

@siddharth-krishna siddharth-krishna changed the title CI Experiment CI: fix GAMS by fixing TIMES_model path, NZ file structure Nov 19, 2024
@siddharth-krishna siddharth-krishna merged commit 4ddec68 into main Nov 19, 2024
2 checks passed
@siddharth-krishna siddharth-krishna deleted the olex/ci-experiment branch November 19, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants