Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GAMS version used in CI #241

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Update GAMS version used in CI #241

merged 4 commits into from
Nov 17, 2024

Conversation

olejandro
Copy link
Member

@olejandro olejandro commented Nov 11, 2024

Fixes #242

@olejandro olejandro marked this pull request as ready for review November 11, 2024 19:19
@olejandro
Copy link
Member Author

@siddharth-krishna looks like this solves the original issue, but points to another one...

@siddharth-krishna
Copy link
Collaborator

I pushed a commit disabling the license stored in the GH secret, and using the inbuilt demo license. It solves the "expired license" issue, but the other issue remains:

*** Error 282 in /scratch/htc/skrishna/xl2times/benchmarks/out/DemoS_001-all/scenario.run
Unable to open include file
Hint: Does the filename need to be quoted?

It looks like there has been some change in Gams between version 44.1 and the latest 48.2 in the way it handles file paths (possibly because our paths contain - or _?). I cannot test v44.1 now because its demo license has expired, I did try v47.6 (the last one with a valid demo license) and it also has the above error. I tried using different values for the FileCase argument, but none of them worked for me on linux.

Olex, could you try running Gams on your machine since you have windows and it has case-insensitive paths? Otherwise we might need to get some help from Gams folks, because I don't know how to debug/fix this issue.

@olejandro
Copy link
Member Author

Sure, I can take a look! I had to deal with something similar on Linux not too long ago, so maybe it is the same solution.

@olejandro
Copy link
Member Author

@siddharth-krishna it looks like GAMS failing is caused by changes in #239.
Undoing the changes to CI, makes it run: https://github.com/etsap-TIMES/xl2times/actions/runs/11882658156/job/33108421476
Let's merge this and fix the CI in #247

@olejandro olejandro merged commit 5d03074 into main Nov 17, 2024
2 checks passed
@olejandro olejandro deleted the olex/update-gams branch November 17, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAMS version used in CI is too old for the demo license
2 participants