Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-118 - Timed out tests should fail on CI #5563

Closed
wants to merge 3 commits into from
Closed

LA-118 - Timed out tests should fail on CI #5563

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a371a5
LA-118 - Timed out tests should fail on CI
andres-torres-marroquin Dec 5, 2024
22f29af
Merge branch 'main' into andres/LA-118
andres-torres-marroquin Dec 6, 2024
39f975f
QA
andres-torres-marroquin Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/backend_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ jobs:
'"pytest(nox)"',
]
runs-on: ubuntu-latest
continue-on-error: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep this one, so it doesn't stop if Static-Checks fail.

steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -118,7 +117,6 @@ jobs:
Performance-Checks:
needs: Check-Container-Startup
runs-on: ubuntu-latest
continue-on-error: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep this one, so it doesn't stop if Performance-Checks fail.

steps:
- name: Download container
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -206,7 +204,6 @@ jobs:

runs-on: ubuntu-latest
timeout-minutes: 15
continue-on-error: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want it to continue to check even if Check-Container-Startup failed?

steps:
- name: Download container
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -255,7 +252,6 @@ jobs:

runs-on: ubuntu-latest
timeout-minutes: 45
continue-on-error: true
steps:
- name: Download container
uses: actions/download-artifact@v4
Expand Down
Loading