LA-118 - Timed out tests should fail on CI #5563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5563/merge
|
| Run status |
|
| Run duration | 00m 49s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
.github/workflows/backend_checks.yml
Outdated
| @@ -92,7 +92,6 @@ jobs: | |||
| '"pytest(nox)"', | |||
| ] | |||
| runs-on: ubuntu-latest | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
We may want to keep this one, so it doesn't stop if Static-Checks fail.
.github/workflows/backend_checks.yml
Outdated
| @@ -118,7 +117,6 @@ jobs: | |||
| Performance-Checks: | |||
| needs: Check-Container-Startup | |||
| runs-on: ubuntu-latest | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
We may want to keep this one, so it doesn't stop if Performance-Checks fail.
.github/workflows/backend_checks.yml
Outdated
| @@ -206,7 +204,6 @@ jobs: | |||
|
|
|||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 15 | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
Do we want it to continue to check even if Check-Container-Startup failed?
andres-torres-marroquin
requested review from
erosselli and
adamsachs
and removed request for
erosselli
adamsachs
approved these changes
Dec 6, 2024
|
Superceded by #5571 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description Of Changes
Timed out tests should fail on CI, they are now actually failing on timeout.
Code Changes
continue-on-errorforSafe-TestsSteps to Confirm
continue-on-errorforSafe-TestsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works