Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate /academic-grants-2022 to md #355

Open
wants to merge 3 commits into
base: markdown
Choose a base branch
from

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented Mar 14, 2024

Description

Migrates the /academic-grants-2022 landing page to md.

Preview: https://deploy-preview-355--ecosystem-support.netlify.app/academic-grants-2022

Comment on lines +8 to +14
**We're calling all those interested in expanding academic knowledge throughout the Ethereum ecosystem!**

The Ethereum community has grown immensely as developers, artists, companies, and even governments work together to make a positive impact with this technology.

With this grants round, the Ethereum Foundation welcomes more academics to the table to push forward formal academic research in related domains. Such domains include theoretical and applied cryptography and mathematics, zero-knowledge proofs, economics, computation, cybersecurity, protocol and consensus mechanisms, formal verification, P2P networking, and hardware, just to mention a few areas.

The Ethereum Foundation is excited to expand Ethereum's reach across more of academia through this grants round.
Copy link
Member

@corwintines corwintines Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to be in section with the id description

 <section id='description' ref={ref}>
    <PageSubheading mb={8}>
      We&apos;re calling all those interested in expanding academic knowledge
      throughout the Ethereum ecosystem!
    </PageSubheading>

    <PageText mb={6}>
      The Ethereum community has grown immensely as developers, artists, companies,
      and even governments work together to make a positive impact with this
      technology.
    </PageText>

    <PageText mb={6}>
      With this grants round, the Ethereum Foundation welcomes more academics to the
      table to push forward formal academic research in related domains. Such domains
      include theoretical and applied cryptography and mathematics, zero-knowledge
      proofs, economics, computation, cybersecurity, protocol and consensus
      mechanisms, formal verification, P2P networking, and hardware, just to mention a
      few areas.
    </PageText>

    <PageText>
      The Ethereum Foundation is excited to expand Ethereum&apos;s reach across more
      of academia through this grants round.
    </PageText>
  </section>

Which resulted in a summary item in the sidenav

Screenshot 2024-03-16 at 11 58 27 AM

Just wondering if this is intentionally not there anymore, or maybe its missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation. The thing is that this is not something I have added support for, because now every heading will appear in the sidebar. So I made that heading bold to avoid having it in the sidebar.

Then, in the case of the Summary section, this is a special case that I also didn't add support for. It is special because it has a hidden heading in the content. With this implementation we would have to add a heading like ### Summary to appear in the sidebar.

Let me see if we can do something about that.

isClosed: true
---

**We're calling all those interested in expanding academic knowledge throughout the Ethereum ecosystem!**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bold section at the top looks different between prod and this PR
Screenshot 2024-03-16 at 12 00 59 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I've answered this also in the prev comment but in short, now every heading in the md file will appear in the sidebar, so we will need to tweak it a bit to avoid that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a Summary component + a hasSummary frontmatter prop to display the summary link in the sidenav 4fa8069

@pettinarip
Copy link
Member Author

@corwintines I've fixed the mentioned issue with the Summary link and also the issue detected in #341 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants