Markdown for landing pages #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
samajammin,
wackerow,
corwintines and
nhsz
as code owners
corwintines
requested changes
Mar 16, 2024
There was a problem hiding this comment.
Nice one @pettinarip!
Looks almost there, just found a few things which I made note of in #355 which should be fixed up in this PR. I can bring them over here if you'd like, just has more context in the other PR.
corwintines
reviewed
Mar 16, 2024
There was a problem hiding this comment.
I think there may be a bug in this file. Noticing when I scroll past the Frequently asked questions header it jumps the sidenav active hash to the top one
Screen.Recording.2024-03-16.at.12.19.11.PM.mov
There was a problem hiding this comment.
Ah good catch, will take a look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support to markdown to build landing pages.
IMPORTANT NOTE
This PR only covers the logic to support md, that is why you will not see any real example using md here. Check #355 to see an example (this PR should be merged first, I broke it out to make it easier to review).