Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get real Flash Chip Size via API call #7159

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Get real Flash Chip Size via API call #7159

merged 4 commits into from
Sep 7, 2022

Conversation

Jason2866
Copy link
Collaborator

actually only the value from the IDE which has been set is read from magic header.
Now the real size is read from the flash chip.

Credits got to @Staars

Fixes #7157

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

@Jason2866 Jason2866 mentioned this pull request Aug 22, 2022
Closed
@VojtechBartoska VojtechBartoska added this to the 2.0.5 milestone Aug 24, 2022
@Jason2866 Jason2866 mentioned this pull request Aug 24, 2022
Closed
@me-no-dev
Copy link
Member

Have you tried this on OPI flash?

@Jason2866
Copy link
Collaborator Author

Have you tried this on OPI flash?

No, sorry to say i have no S3 with OPI

@Jason2866
Copy link
Collaborator Author

Jason2866 commented Aug 25, 2022 •
edited
Loading

Just my 2 cents. Real S3 support is still missing in mandantory tools espressif/esptool#730
espressif/esptool#768

@TD-er TD-er mentioned this pull request Aug 30, 2022
Closed
1 task
@VojtechBartoska
Copy link
Contributor

@P-R-O-C-H-Y will test with OPI

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Sep 6, 2022 •
edited
Loading

Runned @Jason2866 's sketch from linked issue on ESP32S3 with 32MB OPI flash. In Arduino IDE tools menu a have selected 16 MB Flash size (no 32 MB option) with 16MB partition. So seems to be working great with OPI flash :) Good job @Jason2866 👍

ESP32 SDK: v4.4.2-1-gce1fde4b3b
ESP32 DEVICE: ESP32-S3
ESP32 CPU FREQ: 240 MHz
ESP32 XTAL FREQ: 40 MHz
ESP32 APB FREQ: 80.0 MHz
ESP32 FLASH CHIP ID: 3768514
ESP32 FLASH CHIP FREQ: 80.0 MHz
ESP32 FLASH REAL SIZE: 32.00 MB
ESP32 FLASH SIZE (MAGIC BYTE): 16.00 MB
ESP32 FLASH REAL MODE: Fast
ESP32 FLASH MODE (MAGIC BYTE): 3, 0=QIO, 1=QOUT, 2=DIO, 3=DOUT
ESP32 RAM SIZE: 388.85 KB
ESP32 FREE RAM: 364.94 KB
ESP32 MAX RAM ALLOC: 295.99 KB
ESP32 FREE PSRAM: 7139.33 KB

@P-R-O-C-H-Y P-R-O-C-H-Y merged commit 37cbaec into espressif:master Sep 7, 2022
@Jason2866 Jason2866 mentioned this pull request Sep 11, 2022
Merged
@Jason2866 Jason2866 deleted the patch-3 branch September 11, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@SuGlider SuGlider SuGlider approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

ESP32 Flash size read via API is wrong when flash is in modes qio, dio, qout
5 participants
@Jason2866 @me-no-dev @VojtechBartoska @P-R-O-C-H-Y @SuGlider